Re: [Freeciv-Dev] cranky mode mail

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Daniel Sjolie wrote:

> Comments!!!! Please!!!
> And why can noone indent decently???
> Use a tab to indent!!!
> If You feel that You are getting to far to the left with
> tab-indentations You should rewrite tyhe code anyway!
> 
> And what about the if (0) stuff?
> And a switch consruct with one case in it???
> And don't write numbers in the code!!!
> Use constants! With long and descriptive names...
> And a main() with more than 300 lines is not right...
> Ever heard of functions?

Amen!  Preach it, brother!!  :-) :-)

Ever since I became involved in maintaining freeciv I've been
intending to improve some of these things, but have not had 
the time to do much.  

(Except the if(0) stuff for debug messages I would defend: it 
makes it easy to toggle individual messages on/off in the code, 
and the if()'s should optimise away when compiled.  But in any
case there is a patch which will make this unnecessary.)

> Linux kernel coding style:

> 'Chapter 1: Indentation

What _I_ would prefer is for people to use the "freeciv style"
of indentation, even if they don't personally prefer it (even
though _I_ don't personally prefer it) (and even if it 
does not match the "linux kernel coding style" ;-)

Otherwise we get an ugly mix of all sorts of different indentation
styles spread through the code.

(People have suggested doing a big re-indent of the whole code 
sometime, but I don't really think thats necessary.  It would make
it harder to use old diffs, and harder to use CVS to compare vs 
older versions.  But maybe.)

Regards,
-- David