Re: [Freeciv-Dev] config.h patch

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Per Mathisen wrote:
> On Fri, 13 Nov 1998, David Pfitzner wrote:
> > One question: in Markus Linnala's he used:
> >  #ifdef HAVE_CONFIG_H
> >  #include <config.h>
> >  #endif
> > while you just use
> >  #include <config.h>
> > 
> > Was that deliberate on you part? The former seems a good idea to me.
> 
> I did not include them because I did not understand why they were
> included. The way I though about it, an Imakefile compile would read the
> default config.h shipped with the code (which could be hand-edited by 
> the user), and get the default values there.
> 
> Granted, I know nothing about Imakefiles

Me neither :-(

But should we even include a default config.h in the distrib?

I would think the best thing to do would be to use #ifdef around the 
#include <config.h> and then the Imakefile can choose to define 
HAVE_CONFIG_H or not as it likes.

-- David