Re: [Freeciv-Dev] config.h patch

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Per Mathisen wrote:
> 
> Is there interest in moving freeciv autoconf to config.h instead of using 
> dozens of -D compile time messages?

I think it is probably a good idea.

Presumably it also allows us the check whether configure is being 
used (as opposed to the unsupported Imakefile and Makefile.noimake)
eg:
 #if !defined(HAVE_CONFIG_H) || defined(HAVE_STRERROR)
   /* use real strerror */
 #else
   /* workaround */
 #endif
Or is that a bad approach in general and/or in this case?

One question: in Markus Linnala's he used:
 #ifdef HAVE_CONFIG_H
 #include <config.h>
 #endif
while you just use
 #include <config.h>

Was that deliberate on you part?  The former seems a good idea to me.

-- David