Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2006:
[Freeciv-Dev] (PR#15751) Original string bugs/typos, batch
Home

[Freeciv-Dev] (PR#15751) Original string bugs/typos, batch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: sini.ruohomaa@xxxxxx
Subject: [Freeciv-Dev] (PR#15751) Original string bugs/typos, batch
From: "Daniel Markstedt" <himasaram@xxxxxxxx>
Date: Wed, 8 Mar 2006 21:28:35 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15751 >

> > > > server/citytools.c:1854 Don't put the space in the translateable
> > > > substring, put it between the %s%s so we can do punctuation where it
> > > > should be.
> > > I didn't follow you here. :-)
> > 
> > I assume the first one is clear?
> > In that particular case I think the string was 
> > "Cannot complete <building>< from the worklist>"
> > If the option for < from the worklist> is another explanation, it's
> > nicer to have the space in the complete sentence:
> > "Cannot complete <building> <from the worklist>"
> > However, if you presume to put the empty string <> as the latter %s
> > sometimes, I can see why you'd put them together that way (to avoid the
> > extra space). In that case it's unfortunate but fine. ;)
> > 
> 
> Ok, I follow you now. :) I can't see either why this "funky spacing"
> should be. Fixed in updated patch.
> 

No, wait a minute. There's a reason for the "funky spacing". See, when
no 'source' is specified you would get an excessive space then period.
The first version of this patch should be committed.

-Daniel



[Prev in Thread] Current Thread [Next in Thread]