[Freeciv-Dev] Re: (PR#15751) Original string bugs/typos, batch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15751 >

Daniel Markstedt wrote:

>>server/cityhand.c:387 and others suggest translating string
>>"%s". Absolutely needs a context indicator and preferrably
>>also a translator comment; otherwise in practice
>>untranslateable. Should be translateable, not marked untranslateable.
> 
> I just suppose these kind of strings never have to be altered by 
> translators. Such as the name of a nation etc.

You would never have to translate "%s", though the content should of 
course be translated (and most likely is).

Probably this string used to be _("Game: %s") before the "Game: " part 
was cut out...

A side note: in the code

     notify_player(pplayer, pcity->tile, E_BAD_COMMAND,
                     "%s",  message);

the "%s" is acutally needed...because message may contain % or other 
meta-characters which are not properly escaped.

-jason