Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2005:
[Freeciv-Dev] Re: (PR#12841) city_luxury_need function
Home

[Freeciv-Dev] Re: (PR#12841) city_luxury_need function

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#12841) city_luxury_need function
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 21 Apr 2005 09:20:27 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12841 >

Per I. Mathisen wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12841 >
> 
> On Wed, 20 Apr 2005, Jason Short wrote:
> 
>>>The function is "wrong", as its function comment indicates, by not
>>>taking specialists into account. You can "fix" this by passing in the
>>>number of specialists as an additional parameter, and pass this
>>>further on to citizen_base_mood().
>>
>>The comment say it's wrong, it just makes a note. Only by knowing the
>>details of how luxury works will one realize this means the function is
>>wrong.
> 
> I have no idea what you are saying here... Sorry.

Sorry, I, err, mis-edited.  The comment *doesn't* say the function is
wrong.  You have to understand what the comment says to know that the
function is wrong.

P.S.  If an unhappy citizen is turned into a (content) specialist, maybe
another unhappy citizen should be turned angry?

-jason





[Prev in Thread] Current Thread [Next in Thread]