[Freeciv-Dev] Re: (PR#12841) city_luxury_need function

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12841 >

On Mon, 18 Apr 2005, Jason Short wrote:
> This patch adds a function city_luxury_need().
>
> As you may be thinking already, this is taken exactly from Per's patch
> in 12734.The only difference is that I added an assertion in
> generic_city_refresh to make sure it works.
>
> Oh, and the assertion fails.So either the assertion is wrong (I don't
> think so) or the function is.

The function is "wrong", as its function comment indicates, by not taking
specialists into account. You can "fix" this by passing in the number of
specialists as an additional parameter, and pass this further on to
citizen_base_mood().

> Unless this problem can be fixed (and I don't see how it can be, without
> changing the rules a bit) I don't think this function is useful. To be
> useful for the CM (which it would be!) the function has to be 100% correct.

Do the above and it will be 100% correct, AFAIK.

> Now, this issue is at the heart of a larger problem.Specialists do not
> have happiness status.They are not counted in the
> content/happy/unhappy arrays.Aside from being not-quite-logical this
> means any sort of all-specialist ruleset would always have content
> (never happy or unhappy) cities.

Yeah - not good. But I do not think that giving specialists happy/unhappy
status is a good idea.

> With a MoM ruleset this is particularly a problem.MoM doesn't have
> unhappy or happy cities, only *citizens* who are in revolt.A citizen
> in revolt produces no output but has no other effects.

This is somewhat similar to the 'angry citizen'. I think angry citizens
should be a kind of forced specialist - IIRC they have no output now, but
they are still placed on the map. Citizens in revolt would then be angry
citizens.

  - Per