[Freeciv-Dev] Re: (PR#12841) city_luxury_need function

["Benoit Hudson" <bh@xxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12841 >

Attached.

There's a comment that the celebrate code is buggy, but now I'm not sure
I believe the order code either: it doesn't take account of happy
citizens -- if the city has more happy than unhappy, it still says we
need luxuries.  Perhaps we should do:
        int luxneeded = 0;
        while(makes_happy(luxneeded, specialists, happy, content, ...)) {
          luxneeded += HAPPY_COST;
        }
and check makes_happy using citizen_luxury_happy.

        -- Benoît