[Freeciv-Dev] Re: (PR#10125) Pollu_Prod_Pct

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10125 >

On Wed, 15 Sep 2004, Jason Short wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10125 >
>
> Per I. Mathisen wrote:
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=10125 >
> >
> > On Wed, 15 Sep 2004, Jason Short wrote:
> >
> >>The bug is in README.effects. This patch fixes it.
> >
> > Then the effect's name is in error. PCT stands for "percent". It does not
> > use a percentage. It would be better to call it "Pollution_Divisor" or
> > something, although why it does not use a percentage, or how it divides, I
> > do not understand.
>
> It does not use a percentage because multiple effects are additive.  If
> you have one -66% effect (aka 3) and one -50% effect (aka 2) these
> should not sum up to be -116%.  They _should_ be applied in series, so
> it sums up to -84% (aka 6).  However the way it is now they are summed
> up in parallel, so it sums up to -80% (aka 5).
>
> However I was under the impression when I wrote this that it was
> actually a problem for the default ruleset.  Because of the "janitors"
> group this is not the case.

The "janitors" group is indeed precisely for this. Using either divisors
or percentages will work fine.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa