[Freeciv-Dev] Re: (PR#10125) Pollu_Prod_Pct

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10125 >

On Wed, Sep 15, 2004 at 10:06:32AM -0700, Per I. Mathisen wrote:
> 
> I still do not understand
>   1) why its name contains PCT (percent) even though it does not use
> a percentage value
>   2) why this strange way of calculating pollution is used
> 
> Could it not be easier solved by using a percentage value? Pollution is
> reduced by the given percentage value. For recycling center, pollution is
> increased by 66% but reduced by 50% if you have a nuclear plant or a hydro
> plant. This is possible using existing effects:
> 
> effect         =
>     { "name", "range", "value", "req_type", "req"
>       "Pollud_Prod_Pct", "Player", 66
>       "Pollud_Prod_Pct", "Player", -50, "Nuclear Plant"
>       "Pollud_Prod_Pct", "Player", -50, "Hydro Plant"
>     }
> 
>   - Per

it was originally named that because old effects code used it as a
percentage, and when the decision was made (??) to use it as a divisor,
the name wasn't changed with it.

I'm with you Per, it should be a percentage. Period. and the percentages
should be additive (which we don't have a choice about really).

-mike