[Freeciv-Dev] Re: (PR#8754) effects patch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >


+/**************************************************************************
+...
+**************************************************************************/

There are still some functions with empty comments.

-----

I don't see any design-independent parts that can be easily split off 
(though I will keep looking).  This still leaves a 250k monstrosity. 
There is the alternative of taking the design and implementing it 
step-by-step.  However I think this is what you guys already decided was 
not a good idea.  If you still think that, then now is when we should 
start seriously preparing the entire thing for inclusion.

P.S.  Lots of playtesting is needed.  Playtesting the current ruleset is 
  helpful.  Developing new rulesets to be playtested would also be helpful.

jason