[Freeciv-Dev] Re: (PR#8754) eff beta6: missing req_type, etc

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Mon, 26 Jul 2004, Per I. Mathisen wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
>
> In the default ruleset, there is a effect req_type "wonder". This does not
> seem to be supported.
>
> 1: for Research Lab unknown requirement type: "Wonder"
> (data/default/buildings.ruleset)

I see no such thing:

+ { "eff", "range", "value", "equiv", "req_type", "req"
+ "Science_Bonus", "Player", 50, "Labs", "City_Has_Building", "Library"

> Also, civ1 and civ2 rulesets are not updated with the new effects.

I saved that for post commit. The patch is quite big as it is. It is only
a matter of changing rulesets, but the patch is big.

> Finally, the patch contains this change to civ1 buildings.ruleset, which
> should not be in this patch, AFAICT:
>
>  [building_hoover_dam]
>  name           = _("Hoover Dam")
>  tech_req       = "Electronics"
>  bldg_req       = "None"
>  graphic                = "b.hoover_dam"
>  graphic_alt    = "-"
>  terr_gate      = "Mountains"
>  spec_gate      = "River"
> -equiv_range    = "Player"
> +equiv_range    = "Island"
>
>  [building_js_bachs_cathedral]
>  name           = _("J.S. Bach's Cathedral")
>  tech_req       = "Religion"
>  bldg_req       = "None"
>  graphic                = "b.js_bachs_cathedral"
>  graphic_alt    = "-"
>  ;terr_gate     =
>  ;spec_gate     =
> -equiv_range    = "Player"
> +equiv_range    = "Island"

Ok, I'll remove that and make a separate patch.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa