[Freeciv-Dev] Re: (PR#8754) effects patch

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Sat, 24 Jul 2004, Jason Short wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
>
> In the network code, why do you replace the effects array with a
> separate packet for each effect?  Is there a reason the individual

For all sorts of reasons.

> packets are better (e.g., the array would be sparse) or do you just not

Yes, the array is sparse.

> like using dataio functions for sending struct arrays (which is ugly)?

Yeah, I don't like having to manually code my own struct packing
and unpacking functions just for this special case. It doesn't add
anything worthwhile and increases the maintenance burden.

> Why is PACKET_RULESET_CACHE_EFFECT called that?  It looks to me like
> it's not a cache, it's just the effect...

It's an Effect in the Ruleset Cache. Hm, but yeah, I suppose I could just
call it effect. They aren't stored anywhere else...

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa