[Freeciv-Dev] Re: (PR#8754) effects patch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

Vasco Alexandre da Silva Costa wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
> 
> On Wed, 21 Jul 2004, Jason Short wrote:
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
>>
>>This code:
>>
>>+     notify_player_ex(pplayer, -1, -1, E_TECH_GAIN,
>>+         _("Game: %s acquired from The Great Library!"),
>>+         advances[i].name);
>>+     gamelog(GAMELOG_TECH, _("%s discover %s (Library)"),
>>+         get_nation_name_plural(pplayer->nation), advances[i].name);
>>+     notify_embassies(pplayer, NULL,
>>+         _("Game: The %s have acquired %s"
>>+           " from the Great Library."),
>>+         get_nation_name_plural(pplayer->nation),
>>+         advances[i].name);
>>
>>should not hard-code "Great Library" or "(Library)".  Somehow we need to
>>find the source of the effect and tell that instead.
> 
> 
> There can be more than one possible source, depending on the ruleset. The
> effects will be summed up.

I think in both these cases it's possible to find the building to put in 
the string.  But it would take some work.

For now it's okay just to call it a "building".  I don't think it should 
say "from the great library", though.  Others may disagree.

jason