Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2004:
[Freeciv-Dev] Re: (PR#8754) effects patch
Home

[Freeciv-Dev] Re: (PR#8754) effects patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: vasc@xxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#8754) effects patch
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 21 Jul 2004 12:19:39 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

This piece of code:

-  if (city_got_building(pcity, B_COURTHOUSE)) {
-    dist /= 4;
-  }
+  dist -= (dist * get_city_bonus(pcity, EFT_INCITE_DIST_PCT)) / 100;

is logically correct but will, I think, cause savegames to differ 
because the rounding is different.  This may make debugging harder.  It 
would be possible to have

   dist = dist * (100 - get_city_bonus(...)) / 100

instead; it's up to you.

jason




[Prev in Thread] Current Thread [Next in Thread]