[Freeciv-Dev] Re: (PR#8754) effects patch

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Wed, 21 Jul 2004, Jason Short wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
>
> This code:
>
> +     notify_player_ex(pplayer, -1, -1, E_TECH_GAIN,
> +         _("Game: %s acquired from The Great Library!"),
> +         advances[i].name);
> +     gamelog(GAMELOG_TECH, _("%s discover %s (Library)"),
> +         get_nation_name_plural(pplayer->nation), advances[i].name);
> +     notify_embassies(pplayer, NULL,
> +         _("Game: The %s have acquired %s"
> +           " from the Great Library."),
> +         get_nation_name_plural(pplayer->nation),
> +         advances[i].name);
>
> should not hard-code "Great Library" or "(Library)".  Somehow we need to
> find the source of the effect and tell that instead.

There can be more than one possible source, depending on the ruleset. The
effects will be summed up.

> This would help with aqueduct/sewer system as well.  You changed "Needs
> aqueduct" to "Needs a building".  Better would be to find the next
> available source and name it.

There can be more than one possible source, depending on the ruleset.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa