[Freeciv-Dev] Re: (PR#9020) optimization of map_get_tile

["Per Inge Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9020 >

On Fri, 18 Jun 2004, Jason Short wrote:
> There have been discussions before about mass-inlining of functions.
> Arnstein made a patch for map.c, and Per wanted to inline some functions
> in city.c.
>
> My opinion is that changing functions to macro/inline should be done in
> a targeted way. Rather than do it in large batches, we should pick a
> function or two that is heavily used (based on profiling) and optimize
> it.(This applies to other forms of optimization, not just macro/inlining.)

I think we should distinguish here between making public functions
inline/macro, and making private static functions inline.

The former is problematic because it bloats up the headers and causes some
confusion as to where the function is actually implemented. So for this
case I support your proposition above.

However, the latter, turning plain static into static inline, I think a
little less hesitation should be applied.

Of course, some caution should still be applied, though, as inlining a
static function that is used in a lot of places can degrade performance
instead of improving it. So I think static inline should only be used when
the function is only called from a very few places, depending on the size
of the function.

  - Per