[Freeciv-Dev] Re: (PR#9020) optimization of map_get_tile

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9020 >

Gregory Berkolaiko wrote:

>>2.  Use inline instead of macro.
> 
> What is the performance gain with inline?

Seems to be about 4%.

>>3.  Change all users to use "pfmap" instead of "map".
> 
> Is it a hint that the offenders are PF and friends?  I have no problem
> about renaming pfmap, in fact, we should do it anyway.

Well, every "map" variable is a pf map.

>>4.  Rename global "map" as "civ_map".
>>
>>5.  Rename global "map" as "game.map".
> 
> Should be done as well.

In theory, yes.  But it may be more work than it's worth.

jason