[Freeciv-Dev] Re: (PR#9020) optimization of map_get_tile

["Per Inge Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9020 >

On Fri, 18 Jun 2004, Jason Short wrote:
> Per Inge Mathisen wrote:
> > However, the latter, turning plain static into static inline, I think a
> > little less hesitation should be applied.
> >
> > Of course, some caution should still be applied, though, as inlining a
> > static function that is used in a lot of places can degrade performance
> > instead of improving it. So I think static inline should only be used when
> > the function is only called from a very few places, depending on the size
> > of the function.
>
> I disagree.I think it would be better just to enable a higher
> optimization level in the compiler. Static functions can easily be
> automatically inlined by an intelligent compiler, and we can hope it
> will do a better job than we would at guessing which ones are the best
> to inline.

Well, that depends on whether we will actually use a higher optimization
level or not, does it not?

I have my doubts that everyone will agree that running all debug levels in
-O3 is a good idea, and please do not make it so that --enable-debug=yes
is unplayable.

Maybe selectively picking gcc optimizations is a better idea than using
-O3, though.

From the gcc manual: "-O3 turns on all optimizations specified by -O2 and
also turns on the -finline-functions, -fweb and -frename-registers
options. " About -frename-registers and -fweb it says they can "make
debugging impossible", so it might not be a good idea to use them.

  - Per