Complete.Org: Mailing Lists: Archives: freeciv-dev: June 2004:
[Freeciv-Dev] Re: (PR#9020) optimization of map_get_tile
Home

[Freeciv-Dev] Re: (PR#9020) optimization of map_get_tile

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#9020) optimization of map_get_tile
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 19 Jun 2004 21:05:37 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9020 >

rwetmore@xxxxxxxxxxxx wrote:
> You need to explain the problem in more detail or point out a few code 
> locations with conflicts. It is not clear what the issue is for all these 
> options.

See the patches and profiles attached to the ticket.

> First, make the standard macro that takes a (reference) map parameter as its 
> leading argument - effectively option 6. This is often thought of as the 
> "hidden" or zeroth reference to a C++ object. Wherever possible use this as 
> the standard replacement form and way to do things. If you do a proper macro 
> that uses its arguments once, there will be an interesting local variable 
> optimization effect that will have real performance benefits.

This won't fix the naming conflict.

jason




[Prev in Thread] Current Thread [Next in Thread]