[Freeciv-Dev] Re: (PR#9020) optimization of map_get_tile

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9020 >

Per Inge Mathisen wrote:

> However, the latter, turning plain static into static inline, I think a
> little less hesitation should be applied.
> 
> Of course, some caution should still be applied, though, as inlining a
> static function that is used in a lot of places can degrade performance
> instead of improving it. So I think static inline should only be used when
> the function is only called from a very few places, depending on the size
> of the function.

I disagree.  I think it would be better just to enable a higher 
optimization level in the compiler.  Static functions can easily be 
automatically inlined by an intelligent compiler, and we can hope it 
will do a better job than we would at guessing which ones are the best 
to inline.

jason