[Freeciv-Dev] Re: (PR#8797) ocean cities and TER_NO_CITIES

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8797 >

On Fri, May 21, 2004 at 11:12:04PM -0700, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8797 >
> 
> Raimar Falke wrote:
> 
> > A good idea. However you assume in city_can_be_built_here that unit
> > with the "Cities" flag can be built a city anywhere. I think this
> > wasn't the case in SMAC. We need multiple "Cities" flags. And maybe
> > also multiple "Settlers" and "Transform" flags.
> 
> Well, since transported units can't build cities [1] I think it's 
> consistent with SMAC rules.
> 
> [1] This is a change from the existing rules, as you can see in the 
> patch, but simpler and more correct IMO.

You want to remove:

-    /* We allow land units to build land cities and sea units to build
-     * ocean cities. */
-    if ((move_type == LAND_MOVING && is_ocean(map_get_terrain(x, y)))
-       || (move_type == SEA_MOVING && !is_ocean(map_get_terrain(x, y)))) {
-      return FALSE;
-    }

While this is not complete it at least show that there is a difference
between building land and sea cities. You want to remove it. At least
add a fixme 'add multiple "Cities" flags to control which units can
build land and sea cities'.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The Internet is really just a series of bottlenecks 
  joined by high speed networks."
    -- Sam Wilson