[Freeciv-Dev] Re: (PR#8797) ocean cities and TER_NO_CITIES

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8797 >

Raimar Falke wrote:

> You want to remove:
> 
> -    /* We allow land units to build land cities and sea units to build
> -     * ocean cities. */
> -    if ((move_type == LAND_MOVING && is_ocean(map_get_terrain(x, y)))
> -       || (move_type == SEA_MOVING && !is_ocean(map_get_terrain(x, y)))) {
> -      return FALSE;
> -    }
> 
> While this is not complete it at least show that there is a difference
> between building land and sea cities. You want to remove it. At least
> add a fixme 'add multiple "Cities" flags to control which units can
> build land and sea cities'.

But there is no FIXME because the behavior isn't changed.  Because I add in

   if (punit->transported_by != -1) {
     return FALSE;
   }

jason