[Freeciv-Dev] Re: (PR#8749) Scenario fixes

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8749 >

Mike Kaufman wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8749 >
> 
> On Sat, May 15, 2004 at 05:39:23PM -0700, Jason Short wrote:
> 
>>>I guess my only concern is the case where I create a scenario with X
>>>players and X start positions, but on game load I change maxplayers to X+1.
>>>Where does the X+1th player get his starting position from?
>>
>>You can't do that (now, or under our patches).  I have no idea what 
>>happens if you try.
> 
> yes, that's what I'm saying. why shouldn't one be able to do that?

Because it's not possible.  Only the mapgen code can add start 
positions, and it is a tedious process.  There is no reliable way (even 
with mapgen) to add a new starting position without moving around the 
existing ones.

Scenarios, however, should have an option to ignore the given start 
positions and have mapgen create all-new ones.

Under my patch, if you load a scenario then set maxplayers and aifill to 
be larger than the number of start positions, you get a cryptic crash. 
Under the old code, the extra players are removed.  But I have no idea 
what is causing this.

jason