[Freeciv-Dev] Re: (PR#8749) Scenario fixes

["Per Inge Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8749 >

On Sat, 15 May 2004, Per Inge Mathisen wrote:
> Adds a new field to the fixed start positions in savegames which holds the
> nation in text. If present, this is used instead of fixed indexing into
> the nations list, which is a very flawed way to indicate a nation, since
> we add new ones every now and then, throwing the index off track.
>
> Also simplify and sanitize some strange code.
>
> Finally forbid client selection of nations not in the fixed starting
> positions list when we use scenarios with such lists.
>
> Mike, I think you want a look at this, since it impacts on civworld.

Well, this issue is a bit more complicated than what it seemed at first
sight.

We have three cases now:
 1) we get just a map (from savegame or mapgen)
 2) we get a map + positions that should be filled by random
 3) we get a map + positions with fixed order indexing nations
(fixed_start_positions)

Civworld essentially does 2 but (AFAICT erronously) saves
fixed_start_positions=1, so civserver reads it as 3.

I think we should just remove fixed_start_positions. If there are map
positions in the savegame, use them and if they lack a nations field, fill
them by random.

  - Per