[Freeciv-Dev] (PR#8455) Bombardment (aka ranged attack)

["James Canete" <use_less@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8455 >

New version.

Changes:
- minor cleanup, placed some common code in new functions but haven't
redirected old code to them.
- fixed a bug where when "Bombarder" wasn't the last unit flag caused
the bombard values to be reset.  This bug exists with the paratrooper
flag as well, but I didn't fix that.
- bombard can no longer kill a unit.
- bombard can be activated by moving towards an enemy unit now, so if
non-ranged bombardment is desired a ruleset author can set bombard_range
to 1 and attack to 0.

Issues:
-Should bombard rules (such as attack all, pillage, etc) be decided on a
per-unit basis or per-ruleset basis?
-Should there also be a bombard_minrange, so rushing a ranged bombarding
unit is a good way to attack it?

-James Canete

bombard5.diff
Description: Binary data