[Freeciv-Dev] Re: (PR#7517) Move canvas_store functions into client/gui-.../graphics.c

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7517 >

On Sat, Feb 28, 2004 at 09:32:51AM -0800, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7517 >
> 
> Raimar Falke wrote:
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=7517 >
> > 
> > On Thu, Feb 26, 2004 at 12:52:26PM -0800, Jason Short wrote:
> > 
> >><URL: http://rt.freeciv.org/Ticket/Display.html?id=7517 >
> >>
> >>>[i-freeciv-lists@xxxxxxxxxxxxx - Wed Feb 25 07:57:17 2004]:
> >>
> >>>>>Also renamed gui_copy_canvas() to copy_canvas().
> >>>>
> >>>>Why the rename?
> >>>
> >>>The rename is wrong. But we may want to think of a new prefix since
> >>>"gui" is very lame. Something like "cs" for canvas store or similar.
> >>
> >>Why is the rename wrong?  If the other two functions are "canvas"
> >>functions surely this one is too?
> > 
> > 
> > gui_copy_canvas is a drawing operation like gui_put_line. So all
> > functions (drawing and create/destroy) should have the same prefix.
> 
> But this applies to the other "canvas" functions too.  They are all 
> "gui" operations.  IMO they should all get the canvas_ prefix:
> 
>    canvas_create
>    canvas_copy
>    canvas_put_line
>    canvas_put_sprite

Yes. Either "canvas" or "cs".

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The two rules for success in life are:
  1) Never tell them everything you know."