[Freeciv-Dev] Re: (PR#7517) Move canvas_store functions into client/gui-.../graphics.c

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7517 >

On Tue, Feb 24, 2004 at 06:22:01PM -0800, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7517 >
> 
> Jason Short wrote:
> 
> >>Also renamed gui_copy_canvas() to copy_canvas().
> > 
> > Why the rename?
> 
> Err, right.  Because the other functions are canvas_store_create(), 
> canvas_store_free().  But we also have gui_put_sprite, 
> gui_put_sprite_full, gui_put_line, and gui_put_rectangle.  Maybe these 
> should be renamed with s/gui/canvas/?  Note there's also a 
> gui_map_put_tile_iso; this function will eventually be removed.
> 
> This doesn't all have to be one patch, though.  If we decide these 
> functions should go into graphics.c (or a new file canvas.c) we can move 
> them one at a time, in groups, or whatever.

If would have read this email before I answered the other one I would
had to write multiple "ack"s.

> Finally, these functions need function comments.  Should be easy.  In 
> fact, I don't know how they slipped into the code without function 
> comments.  Bad Raimar!

;)

> So I'm in favor of moving them out of mapview.c.  Whether they go into 
> canvas.c or graphics.c I don't much care.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Python 2.0 beta 1 is now available [...]. There is a long list of new 
  features since Python 1.6, released earlier today. We don't plan on 
  any new releases in the next 24 hours."
    -- Jeremy Hylton at Slashdot