Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2004:
[Freeciv-Dev] Re: (PR#7517) Move canvas_store functions into client/gui-
Home

[Freeciv-Dev] Re: (PR#7517) Move canvas_store functions into client/gui-

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: use_less@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#7517) Move canvas_store functions into client/gui-.../graphics.c
From: "Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>
Date: Sat, 28 Feb 2004 09:29:33 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7517 >

On Thu, Feb 26, 2004 at 12:52:26PM -0800, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7517 >
> 
> > [i-freeciv-lists@xxxxxxxxxxxxx - Wed Feb 25 07:57:17 2004]:
> 
> > > > Also renamed gui_copy_canvas() to copy_canvas().
> > > 
> > > Why the rename?
> > 
> > The rename is wrong. But we may want to think of a new prefix since
> > "gui" is very lame. Something like "cs" for canvas store or similar.
> 
> Why is the rename wrong?  If the other two functions are "canvas"
> functions surely this one is too?

gui_copy_canvas is a drawing operation like gui_put_line. So all
functions (drawing and create/destroy) should have the same prefix.

This is also something the latest patch lack.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 Q:  Do you know what the death rate around here is?
 A:  One per person.




[Prev in Thread] Current Thread [Next in Thread]