[Freeciv-Dev] Re: (PR#7517) Move canvas_store functions into client/gui-.../graphics.c

["Jason Short" <jshort@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7517 >

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7517 >
>
> On Sat, Feb 28, 2004 at 03:07:36PM -0800, James Canete wrote:
>>
>> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7517 >
>>
>> Oh, wait, there already is a struct canvas.  It's only used for
>> mapview_canvas, though.  And there's a definition for an overview struct
>> right below it that looks almost identical, save a couple variables.
>>
>> Perhaps it could be renamed to, say, struct canvas_wrapper or something,
>> since it seems to wrap up a canvas_store with a few
>> non-implementation-dependent variables, and used for both overview and
>> mapview.
>
> The current "struct canvas" is more a "struct mapview" or "struct
> mainmapview".

I like canvas_*** for the functions, struct canvas instead of struct
canvas_store, and struct mapview for the mapview struct (struct overview
for the overview struct).

Note the mapview could be extended to work in multiple places.  For
instance the citydlg view is a special case of the mapview system.  But I
don't think that's a concern at this point.

jason