[Freeciv-Dev] (PR#7324) orders and AI goto conflict

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7324 >

> [guest - Mon Jan 26 21:00:53 2004]:
> 
> Here's another possible (but as of yet, untested) patch. 

When I:

- Start a game with one player.
- Found one city.
- Send my settlers and explorer on goto.
- Aitoggle myself.

I get a server segfault when the settlers _finish_ their orders:

civserver: aitools.c:443: ai_unit_new_role: Assertion
`(punit)->goto_dest.y != -1' failed.

#0  0x400ab571 in kill () from /lib/libc.so.6
#1  0x400ab315 in raise () from /lib/libc.so.6
#2  0x400ac838 in abort () from /lib/libc.so.6
#3  0x400a4a4f in __assert_fail () from /lib/libc.so.6
#4  0x081036f7 in ai_unit_new_role (punit=0x8416eb0,
task=AIUNIT_AUTO_SETTLER,
    x=-1, y=-1) at aitools.c:468
#5  0x0809eb4f in evaluate_city_building (punit=0x8416eb0, gx=0xbffff804,
    gy=0xbffff808, ferryboat=0xbffff80c) at settlers.c:924
#6  0x0809fd4b in auto_settler_findwork (pplayer=0x8237ec8, punit=0x8416eb0)
    at settlers.c:1212
#7  0x080a0267 in auto_settlers_player (pplayer=0x8237ec8) at
settlers.c:1328
#8  0x080a0986 in auto_settlers () at settlers.c:1473
#9  0x080502ae in main_loop () at srv_main.c:1389
#10 0x08050bc6 in srv_loop () at srv_main.c:1701
#11 0x080505ec in srv_main () at srv_main.c:1478

jason