Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2003:
[Freeciv-Dev] Re: (PR#6721) Quincuncial and Mobius topologies ready!
Home

[Freeciv-Dev] Re: (PR#6721) Quincuncial and Mobius topologies ready!

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mburda@xxxxxxxxx, rt-guest@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#6721) Quincuncial and Mobius topologies ready!
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Sun, 28 Dec 2003 13:15:57 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6721 >

On Sun, 28 Dec 2003, Marcelo Burda wrote:
> Happy new year,
> Pleas up a little the priority of this tickets, this is becoming a mega
> patch , the server side and the no iso clients are READY!

I am still waiting for an assessment of the speed impact of this patch. I
want to see some numbers on how it affects game speed both with and
without the exotic topologies in actual use.

Your patch is large and touches a lot of code. We are (slowly) preparing
for a major release. You may have to be patient.

I took a brief look at your patch, and it seems you have not yet read the
coding style document. Be advised that we are in general quite strict on
style issues, and you will need to clean up a lot of that code.

  - Per

PS A patch is not "ready" when it has "fix bugs" in its TODO list.

PPS Keep PR#6972 and PR#6970 separate from this patch.





[Prev in Thread] Current Thread [Next in Thread]