[Freeciv-Dev] Re: client/server authentication (PR#1767)

["ChrisK@xxxxxxxx" <ChrisK@xxxxxxxx>]

On Tue, May 27, 2003 at 09:04:09PM -0700, Mike Kaufman wrote:
> On Tue, May 27, 2003 at 01:36:56PM -0700, ChrisK@xxxxxxxx wrote:
> 
> > When I send the password twice like this, I got rejected with "wrong
> > password", even if the password is correct. The server complains:
> > 1: chris's sending bad auth packets
> 
> the server message for bad auth packets is now LOG_VEROSE and now says
> 'unrequested auth packets'.

So an unrequested auth packet is supposed to let the password check fail?
Ah, ok, makes sense.

> > With wrong password the dialog says: "Your password is incorrect. Try again"
> > A better feedback was if there is the number of tries included e.g. (2/4)
> 
> the desensitization of the next button should go a long way toward
> alleviating this, so I didn't do anything here. I could have the client
> blank the message line when sending, but...

Good idea. ;)

> > Finally, I was lying. I can crash the client when I connect in the startup
> > phase of the server, when it is busy loading a savegame, with the well-known
> > assert:
> > 1: Unexpected buffers in try_to_connect()
> > 1: last message repeated 2 times
> > 1: last message repeated 2 times (total 4 repeats)
> > 1: last message repeated 4 times (total 8 repeats)
> > civclient: clinet.c:320: input_from_server: Assertion `fd ==
> > aconnection.sock' failed.
> > Abgebrochen (core dumped)
> > I also managed to get the client stuck (disconnected) with the enter
> > password dialog, whatever I enter or send, nothing happens, until I quit.
> 
> is this a result of hitting the next button rapidly?

Yes.

> Can you reproduce it with the new patch?

Obviously not. But that doesn't mean you fixed the bug :-P

I *can* still crash it, with a new user name, and holding return key
pressed, in the "Verify password" stage, probably because there is no delay,
with the same assert.

After entering a user name, the game menue is active, probably unwanted, I
can then, with pending auth, "disconnect from server", which makes the
client unusuable until quit.

A password with a space in it is accepted, but not with a space at its end.
Intended?

Christian

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.