[Freeciv-Dev] Re: client/server authentication (PR#1767)

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Fri, May 23, 2003 at 09:05:46AM -0700, Mike Kaufman wrote:
> On Fri, May 23, 2003 at 02:14:12AM -0700, Raimar Falke wrote:
> > > and...? we don't have a connectdlg_common.c yet, and 
> > 
> > > I'm not going to make one for this triviality
> > 
> > Why not?
> 
> well, for one these are not _required_ for all clients.

This means that not all clients will be able to connect to an auth-server?

> Two, we're talking about _one_ enum. I mean come on.

I'm sure we find other stuff. We have to start with something.

> > > > IMHO should a connection have a pointer to a struct user. This field
> > > > should then go.
> > > 
> > > no. I thought about this. This would require that user.h be in common and
> > > that is not right as the client has absolutely nothing to do with that
> > > struct. The client should not have access to it.
> > 
> > Not at all. You don't have to expose the content of struct user if you
> > use a pointer.
> 
> this is six or one-half dozen the other.

> If you put in a struct user, then what's the point of having a
> pconn->username?

Good question.

> and then the client needs to know what's in pconn->user, etc., so I
> think this change is more trouble than it's worth.

So what about putting struct user in common but do something like:

struct user {
  char name[...];
  struct {
    char passwd[...];
  } server;
};

> perhaps I'll take the time to do this as well.

Good.

> I don't understand you.

Doesn't matter.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  +#if defined(__alpha__) && defined(CONFIG_PCI)
  +       /*
  +        * The meaning of life, the universe, and everything. Plus
  +        * this makes the year come out right.
  +        */
  +       year -= 42;
  +#endif
    -- Patch for 1.3.2 (kernel/time.c) from Marcus Meissner