Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2003:
[Freeciv-Dev] Re: (PR#4278) goto.c 1.49

[Freeciv-Dev] Re: (PR#4278) goto.c 1.49

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rt-guest@xxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#4278) goto.c 1.49
From: "Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>
Date: Fri, 23 May 2003 03:48:39 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Thu, May 22, 2003 at 05:26:36PM -0700, Cameron Morland wrote:
> One thing I noticed about the crash behaviour: if you select "goto",
> then pass the mouse over a tile where a valid path is generated, so
> that it traces out a path, then click, it doesn't crash. It only
> crashes if there was never a valid path, ie if you hit 'g' while
> pointing at land, and then moved to the enemy land unit. It still says
> "Didn't find a route to the destination!", but it doesn't crash.

Please Sandor, Mike and Cameron test the attached patch. It fixes at
least the problem Cameron describe above.


 email: rf13@xxxxxxxxxxxxxxxxx
 "The BeOS takes the best features from the major operating systems. 
  It's got the power and flexibility of Unix, the interface and ease 
  of use of the MacOS, and Minesweeper from Windows."

Index: client/goto.c
RCS file: /home/freeciv/CVS/freeciv/client/goto.c,v
retrieving revision 1.49
diff -u -u -r1.49 goto.c
--- client/goto.c       2003/05/15 12:38:11     1.49
+++ client/goto.c       2003/05/23 10:36:32
@@ -239,12 +239,13 @@
     p->start_moves_left = prev->end_moves_left;
   p->path = NULL;
-  p->end_x = p->start_x;
-  p->end_y = p->start_y;
+  p->end_x = -1;
+  p->end_y = -1;
   parameter.start_x = p->start_x;
   parameter.start_y = p->start_y;
   parameter.moves_left_initially = p->start_moves_left;
   p->map = pf_create_map(&parameter);
+  reset_last_part();

[Prev in Thread] Current Thread [Next in Thread]