[Freeciv-Dev] Re: (PR#3936) introducing native coordinates

[Jason Dorje Short <vze49r5w@xxxxxxxxxxx>]

Raimar Falke wrote:
> On Sat, Apr 12, 2003 at 08:24:06AM +0200, Raimar Falke wrote:
>
> > > but square_iterate and other local functions cannot be implemented
> > > in these coordinates
> > Why not? In the worst case I calculate all the vectors by
> > hand and hardcode them. Something like:
>
> Actually there is a "portable" way to do square_iterate: using
> MAPSTEP.
>
> At the start you go radius times NW.
>
> At the body you do a STEP W. This radius times. Than a STEP S. Than
> radius steps E and so on.
This is a clever(ish) way to define an operation on "native" coordinates 
that really uses map coordinates.  Unfortunately, in addition to being 
extremely inelegant it pushes the problem down the chain: how do you 
implement MAPSTEP?
Additionally, you are defining map directions in terms of map 
coordinates, rather than native coordinates - even though you propose to 
remove map coordinates from the code.  If the directions don't even line 
up with your map, how is anyone supposed to understand what's going on?
Finally, and as an additional challenge, how would you hack around the 
problem for map_distance?
Note, all of these are trivial if you are simply willing to do them in 
map coordinates.
jason