[Freeciv-Dev] Re: (PR#2464) patch: restrict techs by nation

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

On Wed, Dec 04, 2002 at 12:27:16PM -0800, Per I. Mathisen via RT wrote:
> 
> On Wed, 4 Dec 2002, Raimar Falke via RT wrote:
> > > And we can't copy the nation requirements, because we may have two
> > > different sets of nation requirements from our two requirement techs.
> >
> > So what is the problem?
> >
> > > For example:
> > >
> > > [advance_sauronsupernavigation]
> > > name   = _("Sauron's Super Navigation")
> > > req1   = "Normal Navigation"
> > > req2   = "Sauronification"
> > > flags  = ""
> >
> > >nations= "Sauron"
> >
> > nations= ""
> 
> This is the problem.
> 
> req1 gives an inheritance of "All", while req2 gives an inheritance of
> "Sauron", and neither is automatically correct, so you must say explicitly
> what the resulting nation allowances should be.

OR or intersection of both sets.

> Your suggestion will only work if both requirements have the same
> set of allowed nations or one has an empty set. And then we'd have
> to introduce the "All" special word to indicate that we mean all
> nations and not inheritance when we give an empty set...

> No, I'd rather spell out all the nation restrictions. It is the
> simplest way. You are trying to make it too complicated.

The simplest way is not always the best one. We see this at our
current network code (duplication all over the place).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  The Software is not designed or licensed for use in on-line control
  equipment in hazardous environments, such as operation of nuclear
  facilities, aircraft navigation or control, or direct life support
  machines. 
    -- Java Compiler Compiler Download and License Agreement