[Freeciv-Dev] Re: (PR#2464) patch: restrict techs by nation

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

On Wed, Dec 04, 2002 at 10:55:43AM -0800, Per I. Mathisen via RT wrote:
> > However I'm against duplication the information. It is already in the
> > req fields of the techs. One step in this direction would be to change
> > your patch so that if a tech has no set of allowed nations the
> > requirement techs are visited.
> 
> In my patch no set of allowed nations means all nations can use it. Then
> it would have to change so that in order to allow all nations to use it,
> you would have to list them all. That's duplication!

That is not a real argument since we can make the rule "if string is
empty it means that it is allowed for every nation". No sane people
would require that the ruleset author have to list all nations.

I see the problem: both cases
(calculate-the-set-of-allowed-nations-via-req and
all-nations-can-use-this-tech) use the empty string. Not a real
problem. For the second case "all" can be used (an addition to listing
all nations which nobody wants but we don't forbid). Requirement: All
root techs (techs which have both requirements set to "None") must
have a non-empty (either "all" or a list of nations) string.

> And we can't copy the nation requirements, because we may have two
> different sets of nation requirements from our two requirement techs.

So what is the problem? 

> For example:
> 
> [advance_sauronsupernavigation]
> name     = _("Sauron's Super Navigation")
> req1     = "Normal Navigation"
> req2     = "Sauronification"
> flags    = ""

> nations  = "Sauron"

nations  = ""

> [advance_sauronification]
> name     = _("Sauronification")
> req1     = "None"
> req2     = "None"
> flags    = ""
> nations  = "Sauron"
> 
> [advance_aragornsupernavigation]
> name     = _("Aragorn's Super Navigation")
> req1     = "Normal Navigation"
> req2     = "None"
> flags    = ""
> nation   = "Aragorn"
> 
> [advance_navigation]
> name     = _("Normal Navigation")
> req1     = "None"
> req2     = "None"
> flags    = ""
> ;nations  = ""

nations  = "all"

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  The trick is to keep breathing.