[Freeciv-Dev] Re: (PR#2464) patch: restrict techs by nation

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

On Mon, Dec 02, 2002 at 03:35:09PM -0800, Per I. Mathisen via RT wrote:
> 
> On Mon, 2 Dec 2002, Raimar Falke via RT wrote:
> > My proposal:
> >  - add a tech flag Root
> >  - a tech with this flag is called root(-tech)
> >  - don't discard roots is they don't have any real requirements
> >  - a root of a tech T is the tech which is a root and directly or
> >  indirectly T depends on
> >  - all (except A_NONE) have exactly one root (checked at ruleparsing)
> > - if no root techs are given in the tech ruleset A_NONE is given the Root 
> > flag
> >  - all players have at the start of the game exactly one root tech
> >  (A_NONE or initial tech). This is called the root of the player.
> >  - a player can only get a tech by any way (huts, advance, diplomat,
> >  diplomacy, ...) if the root of the tech is the same as the root of
> >  the player.
> >
> > The strict_tech is now always TRUE. But don't matter if all player
> > have the same root tech (A_NONE).
> >
> > Now only someone has to code this.
> 
> I don't see any advantages of this over my code. To the contrary, it looks
> much more complicated, both in terms of code and ruleset author
> understanding. The readability of such a tech.ruleset will be very hard.

It _may_ require more code but I think that the effect is that the
ruleset will become easier. You only have to add "Root" to the root
techs. Finished. In your proposal the information is duplicated (in
the requirements and in the allowed nations). And the code can
calculate the one from the other.

> Also you lose the possibility of merging two disjointed trees at a
> higher stage or have some shared techs in two mostly disjointed tech
> trees.

IMHO this is overkill. I could "no modpack author ever will want this"
but this would be to much. Lets say "all current modpack authors will
be satisfied with my proposal".

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I do feel kind of sorry for Microsoft. Their attornies and marketing
  force must have tons of ulcers trying to figure out how to beat (not
  just co-exist with) a product that has no clearly defined (read
  suable) human owner, and that changes on an hourly basis like the
  sea changes the layout of the sand on a beach. Severely tough to
  fight something like that."
    -- David D.W. Downey at linux-kernel