Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2002:
[Freeciv-Dev] Re: (PR#2484) Xaw client colour allocation patch
Home

[Freeciv-Dev] Re: (PR#2484) Xaw client colour allocation patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Reinier Post via RT <rt@xxxxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#2484) Xaw client colour allocation patch
From: Vasco Alexandre Da Silva Costa <vasc@xxxxxxxxxxxxxx>
Date: Wed, 4 Dec 2002 22:18:24 +0000 (WET)

On Wed, 4 Dec 2002, Reinier Post via RT wrote:

> On Tue, Dec 03, 2002 at 03:17:33PM -0800, Vasco Alexandre Da Silva Costa via 
> RT wrote:
> >
> >
> > Hello,
> >
> > This patch moves some colour allocation code used for PNG loading in
> > graphics.c to colors.c. It also replaces the old colour allocation code.
> > As a bonus this code should allow the Xaw client to run on grayscale and
> > monochrome displays. This will require removing get_visual().
> > It should also now startup on 16 colour displays.
> > One thing it does differently is it no longer tries to use a private
> > colormap on pseudo-color displays when it runs out of entries in the
> > colormap. But I always found that very annoying.
>
> I have to test this.  I think Freeciv must continue to support running
> in 8 bit mode.  This is important on older hardware that doesn't support
> high resolutions in >8 bit mode.  The switch to PNG threatens to kill
> this altogether.

It should work fine. But please test.

> Another thing that would be nice is better color allocation for nations,
> e.g. the scheme used on civserver.freeciv.org.

I don't think I understand what you mean. But changing the colors we use
could have unwarranted effects since IIRC the trident tileset reuses these
colors in the drawings so the client only requires 64 colors total with it.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa



[Prev in Thread] Current Thread [Next in Thread]