[Freeciv-Dev] Re: Civ 2 style happiness (PR#1436)

[Davide Pagnin <nightmare@xxxxxxxxxx>]

        Hi all!

On Sat, 11 May 2002 11:26:47 -0700 (PDT), Reiner Post wrote:
> > On Mon, 6 May 2002, Raahul Kumar wrote:
> > > The current implementation of specialists is wrong. Civ 2 has specialists 
> > > taken
> > > from content citizens. If there are no content citizens, unhappy citizens 
> > > are
> > > used instead.
> > >
> > > The current Freeciv implementation is very buggy, in that unhappy 
> > > citizens are
> > > considered first! This makes elvises not very useful, as the same amount 
> > > of
> > > taxmen or scientists solve your happiness problems just as well.
> > 
> > Do people agree that this is a bug, and one that needs fixing now before
> > the release?
> 
> I don't recall it seeing reported before, and it sure looks like a bug.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Perhaps you and many others on this mailing list don't remember, put I
have
submitted that patch (the specialists patch has been written by me and
Marco Colombo)
in may 2001 and reposted it in june 2001, but it was 1.12.0 "feature
freeze" time...
(I have to say that many other BUGS have been fixed in those month, but
this was not...)

if you like archaelogy:

May 2001, first posting:
http://arch.freeciv.org/freeciv-dev-200104/msg00268.html
Thue reply:
http://arch.freeciv.org/freeciv-dev-200104/msg00300.html

June 2001, second posting:
http://arch.freeciv.org/freeciv-dev-200105/msg00037.html
http://arch.freeciv.org/freeciv-dev-200105/msg00038.html

> 
> -- 
> Reinier

As you said, Reiner, this is not a feature but a bug, in freeciv default
settings 
it is oltrageously easy to make citizen content, and this specialist
behaviour 
made the problem worst.

For the sake of clarity, what is unfair is to pick the worst problem of
your
city (an unhappy or, if you have turned them on, an angry citizen) and
transform
it in a content citizen, that produce science or tax.
Someone can say that freeciv specialists are implemented in this way,
and this
is a matter of fact, but civ II specialists definitely behave in a
different way!

        Ciao, Davide

P.S. In the unlikely event that this patch have is way into CVS I will
appreciate
very much if it is recorded that this patch has been first submitted by
me, and 
that Marco Colombo have helped me in making the patch. 
(Obviously I thank you very much Raahul, to whom I sent my set of Civ II
compliance 
patches, and that have taken this Civ II crusade, and that is fighting
for it).