Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2002:
[Freeciv-Dev] Re: [Patch] Add buy info
Home

[Freeciv-Dev] Re: [Patch] Add buy info

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Vasco Alexandre Da Silva Costa <vasc@xxxxxxxxxxxxxx>
Cc: Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>, Christian Knoke <ChrisK@xxxxxxxx>, freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [Patch] Add buy info
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 26 Feb 2002 11:34:32 +0100
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Tue, Feb 19, 2002 at 05:47:02AM +0000, Vasco Alexandre Da Silva Costa wrote:
> On Mon, 18 Feb 2002, Mike Kaufman wrote:
> 
> > On Mon, Feb 18, 2002 at 11:01:59AM +0100, Raimar Falke wrote:
> > > On Sun, Feb 17, 2002 at 11:04:20PM +0100, Christian Knoke wrote:
> > > > On Sun, Feb 17, 2002 at 03:29:19PM -0600, Mike Kaufman wrote:
> > > > > 
> > > > > attached new version. fixes the sell problem, divides label into 3.
> > > > 
> > > > I like it.
> > > > 
> > > > > There is a problem here, because the dialog size will change slightly 
> > > > > if
> > > > > cost moves from 3 to 4 digits for example. I don't know how to solve
> > > > > this cleanly. Maybe vasc has some idea.
> > > > 
> > > > No problem, I think, because when it has resized once it keeps its
> > > > size, which I think is the best it can do.
> > > 
> > > > I personally would deactivate the change button, when changing is
> > > > forbidden, and deactivate the buy button when there is not enough
> > > > gold (thus making 1 popup superfluous). But that may be a matter 
> > > > of taste.
> > > 
> > > Ack. This was the original intention of the change.
> > 
> > ok, this ought to be the last rev of this sucker.
> > buy button now desensitized when you don't have enough cash
> > 
> > vasco, do you have any thoughts on the window resize issue?
> > otherwise should be committed.
> 
> I still don't understand why you think the progress bar is expensive. But
> anyway...
> 
> I will look at this patch tomorrow. I would have looked at it earlier, but
> i haven't read my e-mail for a couple of days because i've been busy. I
> was also busy today (as you can see i'm posting this at 5:45 AM :-))

[ one week later ]

And?

It is ok for me.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The very concept of PNP is a lovely dream that simply does not translate to
  reality. The confusion of manually doing stuff is nothing compared to the
  confusion of computers trying to do stuff and getting it wrong, which they
  gleefully do with great enthusiasm." 
    -- Jinx Tigr in the SDM


[Prev in Thread] Current Thread [Next in Thread]