[Freeciv-Dev] Re: [PATCH] aiunit.c ai_military_findvictim() cleanup (PR#1264)

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raahul Kumar <raahul_da_man@xxxxxxxxx> wrote: 
> 
> --- Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> wrote:
> 
> > I suspect the idea of patt is to force punit to attack a stack of units
> > if they are endangering punit, even if they are not that weak...
> 
> So this is the reason that the ai makes senseless attacks. Any change of
> convincing the AI not to attack veteran fortified mech inf on mountains any
> time soon ?

what can I say,
have a look at the function, see if you can improve it.

If you give me a savegame with AI attacking fortified mech on a mountain, I
will also have a go.

> > How about writing a separate function 
> > > > consider_pillaging(x, y, punit) ?
> > > > in general, not only barbarians should pillage.
> > > 
> > > Is it used anywhere else?
> > 
> > could be but I don't think so.
> > but it shouldn't stop you IMO
> 
> Making AI units pillage roads and railroads could be a very bad idea. The AI
> might never succeed in taking cities if it pillages roads/railroads along
> the way.

You are right.  But I was thinking more about mines and irrigation.

> > I think we should make many small functions with good names, like
> > consider_defending_town, consider_pillaging, consider_hut_poaching and
> > has_passangers.
> 
> I think you meant has_passengers.

yep.

> > Somehow I like it more.  Don't really know why.
> > BTW, there is still one apetency lurking...
> > 
> 
> Apetency?

Yes, it is a little green animal, mostly harmless but can cause
misunderstanding (just like now) ;)
It was lurking in Petr's patch...

G.

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com