[Freeciv-Dev] Re: [Patch] Sound8

[Anthony Ferrand <Anthony-Ferrand@xxxxxxxxxx>]

Raimar Falke wrote:
> 
> On Fri, Feb 01, 2002 at 03:21:57PM +0100, Raimar Falke wrote:
> >
> > I have spent the previous days working on the sound patch. The newest
> > version 8 is now in the incoming (too large for the list). Changes
> > since version 7 include:
> >  - reworked audio* to allow a real plugin mechanism without special
> >  cases and #ifdefs (this also allows to change the plugin at runtime
> >  just one call to audio_select_plugin())
> >  - extend README.sound
> >  - add sounds for all improvements (formerly only wonders)
> >  - add alternative fight and move tags
> >  - rename the event tags to be consistent (at least a bit)
> >  - add a mechanism to map "normal" events to sound events
> >  - sound is now always be enabled
> >  - a lot of other small changes
> >
> > TODO:
> >  - adjust civ2sounds.spec to use the new names (I don't have a civ2 cd
> >  handy for this)
> 
> > Please test and review.
> 
> To put it more explicit: I won't commit this patch without review.

I can't get Freeciv compiling with the patch:
civclient.o: In function `main':
/home/ASF2907/test/freeciv/client/civclient.c:109: undefined reference
to `audio_init'
/home/ASF2907/test/freeciv/client/civclient.c:201: undefined reference
to `audio_real_init'
/home/ASF2907/test/freeciv/client/civclient.c:202: undefined reference
to `audio_play_music'
/home/ASF2907/test/freeciv/client/civclient.c:210: undefined reference
to `audio_shutdown'
/home/ASF2907/test/freeciv/client/civclient.c:137: undefined reference
to `audio_get_all_plugin_names'
civclient.o: In function `set_client_state':
/home/ASF2907/test/freeciv/client/civclient.c:542: undefined reference
to `audio_stop'
/home/ASF2907/test/freeciv/client/civclient.c:543: undefined reference
to `audio_play_sound'
[...]

Probably, my own fault... but I think I have patched correctly patch -p1
< sound8.patch and the failed hunk corrected by hand (I have patched the
lastest cvs version)

Regards,

Anthony

-- 
http://www.freeciv.fr.st