[Freeciv-Dev] Re: Coding Style Guidelines

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 06:58 PM 02/01/12 -0600, Mike Kaufman wrote:
>On Sat, Jan 12, 2002 at 10:43:04AM +0100, Raimar Falke wrote:
>> On Fri, Jan 11, 2002 at 09:29:17PM -0600, Chris Richards wrote:
>> > Sub-subject: spacing and -ts0
>> > 

>> > So, I think that any invocation of indent should specify -ts0.

>but if -ts0 makes indent behave better, I'm all for it. What do other
>people think?
>
>-mike

Personally, I'm not a great fan of the K&R tabs&spaces where the tabs 
are not the indent size. Most non-Unix editors can't really handle it
and the result is either non-compliance or people waste a lot of time
doing petty manual fixups.

I work with it everywhere, so I have reflexes by now and can function
but I suspect fewer and fewer new people understand it.

If you are starting from scratch, all spaces is easiest to go with, 
and with indent at 2 is a no-brainer. But the current codebase is 
primarily tabbed 8, with a lot of minor and some major non-compliance.
This means generally it isn't worth doing, but there are probably 
enough holes to get a foot in the door to start opening it.

I wouldn't change an existing file on minor updates, but if the change 
affects most of a routine or more, it is probably not unreasonable to
reset things on a function basis, and do the rest of the file when it
is more than 2/3 converted.

If you set the policy to start converting over, no one should be allowed
to switch code back :-).

Cheers,
RossW
=====