[Freeciv-Dev] Re: Coding Style Guidelines

[Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>]

> > >>- Spaces should go before and after operators, and after commas:
> > > 
> > > indent takes care of this.
> > 
> > indent covers a lot of things, but some of them should perhaps be 
> > explicitly mentioned anyway.
> > 

I agree. not everybody looks up exactly what indent does.
Not everybody uses it. The more important things should be explicitly
mentioned.

>  
> > >>- Always prototype global functions in the appropriate header file.
> > >>  Local functions should always be declared as static.
> > > 
> > > Use "-Wmissing-prototypes -Wmissing-declarations" to catch these.
> > 
> > Shouldn't that then be "Local functions should always be declared as 
> > static and prototyped at the top of the file"?

these should be added to the Makefile if necessary, not put into the
style guide.

> I have no problem if only the needed prototypes are provided for
> static functions.
> 
>       Raimar

attached is a revision:

-mike

README.coding_style
Description: Text document