Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2002:
[Freeciv-Dev] Re: Coding Style Guidelines
Home

[Freeciv-Dev] Re: Coding Style Guidelines

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>
Cc: Freeciv-Dev <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: Coding Style Guidelines
From: Teemu Kurppa <tkurppa@xxxxxxxxxx>
Date: Fri, 11 Jan 2002 10:12:51 +0200 (EET)

On Fri, 11 Jan 2002, Mike Kaufman wrote:

> attached is what I propose to be put in CVS. Hopefully this will start
> the last major thread on this subject. I welcome feedback.

Thank you for putting this together. I've longed for it. 

> /***********************************
>  * 3: comments in code (see also 9:)
>  ***********************************/
> 
> /* A */
> int foo3a(int x)
> {
>   x = 3;    /* assign 3 to x */
> }
> 
> /* B */
> int foo3b(int x)
> {
>   /* assign 3 to x */
>   x = 3;
> }
> 
> because there is some level of contradiction between this and what
> people wanted in the Comments in declarations. Do people still think that A is
> unacceptable here? My opinion is that A is fine anytime you can fit it on a
> single line.

I vote for A, too. Of course, only if it fits on the same line. 

Teemu Kurppa



[Prev in Thread] Current Thread [Next in Thread]