[Freeciv-Dev] Re: Coding Style Guidelines

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Jan 11, 2002 at 04:33:14AM -0500, Jason Short wrote:
> Raimar Falke wrote:
> 
> > On Fri, Jan 11, 2002 at 12:17:14AM -0600, Mike Kaufman wrote:
> > 
> >>attached is what I propose to be put in CVS. Hopefully this will start
> >>the last major thread on this subject.
> 
> Not likely...
> 
> 
> >>- Spaces should go before and after operators, and after commas:
> > 
> > indent takes care of this.
> 
> indent covers a lot of things, but some of them should perhaps be 
> explicitly mentioned anyway.
> 

> >>- Always prototype global functions in the appropriate header file.
> >>  Local functions should always be declared as static.
> > 
> > Use "-Wmissing-prototypes -Wmissing-declarations" to catch these.
> 
> Shouldn't that then be "Local functions should always be declared as 
> static and prototyped at the top of the file"?

I have no problem if only the needed prototypes are provided for
static functions.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "Real Users find the one combination of bizarre
   input values that shuts down the system for days."