[Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> On Fri, Dec 21, 2001 at 04:37:11PM +0000, Gregory Berkolaiko wrote:
> >
> > we will see.
> > I personally think that your patch has everything: it is useful, it
> > got +ve reviews, it even abides coding rules.  
> 
> > But it doesn't seem to be sufficient here.
> 
> Come on. You know how slow I'm. But you should be able to see how I
> advance in the patches. 

Raimar, I have a lot of respect for what you are doing.  Unfortunately
due to you being the only one still commiting code patches from time to
time and also due to your "won't trust any patch until I check it
line-by-line" attitude (which is commendable but not optimal), the queue
of patches is growing (according to my estimates).

> BTW: The fact nobody noticed that #1127 is broken is not a good sign.

Personally I have -0.0 interest in city naming algorithms.  But I'm sure
if you asked people directly, they would take their time to check it
(although they would need to feel that not only their "no", but also
their "yes" will count).  There were many people discussing city-naming
and even submitting patches, init?  So you could pitch them against each
other ;)

Best,
G.

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com