[Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

I agree with Ross completely.  A good maintainer - reviewer - submitter
hierarchy is what we need.

I am ready to review any goto- and pathfinding-related patches and also
AI-related ones (there I have less knowledge though -- but more
enthusiasm).  If asked for a review but cannot find time to do it, I will
explicitly say so.

Best,
G.

 --- "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx> wrote: 
> At 09:45 AM 01/12/22 +0100, Raimar Falke wrote:
> >On Fri, Dec 21, 2001 at 08:02:47PM -0500, Ross W. Wetmore wrote:
> [...]
> >I don't like to force somebody. In the past I have asked for reviews
> >and usually there was none. This shows to me that not many people are
> >willing to spend time outside their "area of interest". This is ok. We
> >are still here on a voluntary basis. However spending time outside his
> >"area of interest" is something a maintainer has to do. I would really
> >like to work more on the agents stuff but I spend the time I have for
> >freeciv at reviewing patches. Patches which touch all other areas but
> >not the agent area.
> 
> I think that by sending in their names reviewers are giving you the
> pre-authorization to ask them specifically to manage a patch through
> the initial cleanup stages. 
> 
> This doesn't mean that they can't indicate up front areas of interest,
> or decline in specific cases for various reasons (i.e. lifestyle -
> girlfriend in town this weekend :-).

Tell your wife that you are going to your mistress, tell your mistress
that you are spending evening with your wife, go to your attic and code,
code, code!

Best,
G.

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com